I wouldn't care. I review the files and see the end results. If it works and doesn't screw the project over, it's a good PR, IMO
Having more commits in PR does it show that person is careless?
depends on the type of commits
Garbage commits on default branch create bad impression
As long as it's delivered and tested, I still don't care.
Humm... more of personal preference
Define garbage commits
fix x oh no fix x finally fix x x took a long time to fix finally yayyyy x fixed
no one does that
they do
idk why would anyone say they fixed X and again fix x
happens a lot lmao
they dont test their code?
idk but I have seen that happen
impressive i thought i do garbage commits(commit half code in first commit then a whole ass full commmit of project)
by half code i mean litterly half code in a file
https://xkcd.com/1296/
well TBH when i do small changes to project(like renaming var or format/optimize imports) i write "Fixed few small stuff"
I do a "misc" commit once in a while, fixing a bunch of stuff to small for a separate commit
true that, some of my commits for my private repos are like: fix stuff rollback stuff fix another stuff undo stuff haha
Well I just put the same shit everytime XD
http://commit.yede.xyz/
Обсуждают сегодня