Im checking the array length of NftForSales array and iterating

Question

Im checking the array length of NftForSales array and iterating

through, if tokenid and tokenaddress and issold = false of the contract and id parsed in, then throw an error. Am i missing something?

#english #programming #solidity

0

27.12.2021

3 ответов

20 просмотров

Moonsea-Admin Автор вопроса

Aaron (Coffee) - https://rmg.io | https://darkalpha.eth.limo
If I understand your use case...it seems like your...

That's using an OR condition. It needs to match all conditions, thats why i used AND

0

27.12.2021

Aaron (Coffee) - https://rmg.io | https://darkalpha.eth.limo

Moonsea-Admin
That's using an OR condition. It needs to match al...

AND seems incorrect. Imagine trying to list a new tokenId for sale from the same collection as one already listed for sale. You'll notice that it will fail because your code is requiring the tokenID to be different AND the collection to be different. Doesn't make sense.

0

27.12.2021

Aaron (Coffee) - https://rmg.io | https://darkalpha.eth.limo · Accepted Answer

Aaron (Coffee) - https://rmg.io | https://darkalpha.eth.limo

If I understand your use case...it seems like your require logic should perhaps be: require((nftsForSale[i].token != tokenAddress || nftsForSale[i].tokenID != tokenID || nftsForSale[i].isSold == true), "NFT already listed");

0

27.12.2021

169 похожих чатов

Im checking the array length of NftForSales array and iterating

3 ответов

Похожие вопросы