Why not just throw and error and i catch it?

Question

Go

Ghazwan Aliesh

Why not just throw and error and i catch it?

0

08.09.2021

15 ответов

12 просмотров

Roman Sharkov

so this... try { f := OpenFile() try { f.Write("foobar") } catch { log.Error("write failed") } } catch { log.Error("open failed") } is easier to you than this? f, err := OpenFile() if err != nil { log.Error("open failed") return } if _, err := f.Write(); err != nil { log.Error("write failed") }

0

08.09.2021

Codexetreme

Roman Sharkov
so this... try { f := OpenFile() try { f....

This is not a good example imo

0

08.09.2021

Ghazwan Aliesh Автор вопроса

Codexetreme
That's how mistakes are made when handling errors

Maybe but if we agree on some interface for the thrown error (error code or something) we can have much less code doing more. I get it that go make it easier to recognize the origin of the error that way but it does affect amount of code I am writing as a developer.

0

08.09.2021

Roman Sharkov

Codexetreme
This is not a good example imo

it's not, sure, but still, try-catch is a very ugly construct IMHO

0

08.09.2021

Ghazwan Aliesh Автор вопроса

Roman Sharkov
so this... try { f := OpenFile() try { f....

The example u gave for traditional approach is kinda unfair imo. if all the functions that might throw and error followed a similar pattern in the error they throw, I will have one try catch.

0

08.09.2021

Codexetreme

Ghazwan Aliesh
The example u gave for traditional approach is kin...

And precisely why try catch is dangerous

0

08.09.2021

Roman Sharkov

Ghazwan Aliesh
The example u gave for traditional approach is kin...

how do you determine which Write call failed without having separate try-catch blocks?

0

08.09.2021

Codexetreme

Roman Sharkov
how do you determine which Write call failed witho...

Exactly

0

08.09.2021

Ghazwan Aliesh Автор вопроса

Codexetreme
And precisely why try catch is dangerous

yeah maybe go is less evil that way now that i think about it. i am just not used to 20 lines functions i guess 😝

0

08.09.2021

Ghazwan Aliesh Автор вопроса

Roman Sharkov
how do you determine which Write call failed witho...

Well in most cases I won't care as long as the error thrown provides enough data about itself. let's say a register user function that calls: validation method, database method. if both method will throw the error with a message and code in it, I will just want to return it. Idc where it failed.

0

08.09.2021

Roman Sharkov

Ghazwan Aliesh
Well in most cases I won't care as long as the err...

what if they don't throw any codes? (happens a lot actually)

0

08.09.2021

Ghazwan Aliesh Автор вопроса

Roman Sharkov
what if they don't throw any codes? (happens a lot...

then the methods are badly implemented, which i realize is what go is trying to protect u from doing.

0

08.09.2021

Marco De Nittis

Roman Sharkov
so this... try { f := OpenFile() try { f....

If you use try catch as if err.. are terrible, if you use in smarter way are very elegant. IMO in several situation go is verbose in error handling, some piece of code I wrote there is more error handling boilerplate than code logic. With try catch, used in the proper way (not as in this example) the whole solution could be more readable and compact. Nevertheless the go error handling has other advantages

0

08.09.2021

Roman Sharkov

Marco De Nittis
If you use try catch as if err.. are terrible, if ...

Elaborate please 🙂

0

08.09.2021

Codexetreme · Accepted Answer

Codexetreme

That's how mistakes are made when handling errors

0

08.09.2021

Похожие чаты

Why not just throw and error and i catch it?

15 ответов

Похожие вопросы