Best way for refactor this code ?

Question

JavaScript

#HaDi

Best way for refactor this code ?

0

30.09.2021

17 ответов

14 просмотров

#HaDi Автор вопроса

Friday Candour [Ask to PM]
Use a bunch of document.querySelectors if you want...

No . I want to optimize and shorten the code

0

30.09.2021

Friday Candour [Ask to PM]

#HaDi
No . I want to optimize and shorten the code

The code has no problem, if you already have a bunch of these in one file then splitting to separate files will make things look cleaner

0

30.09.2021

Thomas

.toggleClass maybe?

0

30.09.2021

Friday Candour [Ask to PM]

Thomas
.toggleClass maybe?

To use toggleClass then he is going to do some refractoring on the Css and html

0

30.09.2021

Thomas

Friday Candour [Ask to PM]
To use toggleClass then he is going to do some ref...

No

0

30.09.2021

Friday Candour [Ask to PM]

Thomas
No

Yes, look properly at the if else block, It shows that the elements has their independent styles apart from what is being toggled

0

30.09.2021

Thomas

Friday Candour [Ask to PM]
Yes, look properly at the if else block, It shows...

ALL .addClass and .removeClass AND the if can be removed and replaced with only .toggleClass without changing any HTML or changing functionality

0

30.09.2021

Thomas

But....

0

30.09.2021

Thomas

The BEST way to refactor this is to remove ALL the JS and use CSS media queries to auto-set dark mode if the user prefers it

0

30.09.2021

Friday Candour [Ask to PM]

Thomas
But....

The one that is not overwritten

0

30.09.2021

Thomas

Friday Candour [Ask to PM]
The one that is not overwritten

What is the name of that class

0

30.09.2021

Friday Candour [Ask to PM]

Thomas
The BEST way to refactor this is to remove ALL the...

True it's a killer for such low functionality

0

30.09.2021

Friday Candour [Ask to PM]

Thomas
What is the name of that class

Am dictating from the way things like this example are likely to be achieved

0

30.09.2021

#HaDi Автор вопроса

Thomas
The BEST way to refactor this is to remove ALL the...

ok . thank you man

0

30.09.2021

Thomas

#HaDi
ok . thank you man

Today's websites shouldn't even have a button for dark mode

0

30.09.2021

#HaDi Автор вопроса

Thomas
Today's websites shouldn't even have a button for ...

The customer requested this

0

30.09.2021

Friday Candour [Ask to PM] · Accepted Answer

Friday Candour [Ask to PM]

Use a bunch of document.querySelectors if you want to convert to raw JavaScript

0

30.09.2021

Похожие чаты

Best way for refactor this code ?

17 ответов

Похожие вопросы