write readable code. If i have an initialized flag, let's say flagA = false; and then a method where there are some if-elses thatchange the value of the flag, should I skip writing the if-elses where the flag is set to false or keep them for clarity? As in "Hey, these are all the possible flows of this piece of code, i know it's redundant but you who are reading this are probably confused by this complex web app". NOTE: the flow is only gonna enter 1 of the if-elses, so once the flag has entered one, the flag will not be modified more. Example: https://pastebin.com/zFCZvyVV Thanks!
Imho, both ways are good depending on the semantics. What actually that flag represents, and what those conditions are? Those are main things that should influence your decision. Whatever makes the code clear. But I would prefer in most cases another option: var case1 = conditinA && conditionB; var case2 = conditionA && conditionC && conditionD; var flag = case1 || case2 ... only if it makes things more readable and easy to understand. Whatever approach you choose, the most important - use meningful names for flag and conditions!
Great answer, thank you!
Обсуждают сегодня