at least, but why does download_media() do nothing if it doesn't find media in the message?
Wouldn't it be more clear if it raised an exception? Seems odd to just silently exit here
https://github.com/LonamiWebs/Telethon/blob/v1/telethon/client/downloads.py#L432
I don't know why it's hard for users to just thing = ..download_media(..) if not thing: print("couldn't find valid media in that message")
Oh true, haha, whoops, overlooked that 🙃 Thanks
second question, yes, probably changing it is a breaking change though
Yeah, I pondered whether it should be behind a boolean flag, but as 天禅あいむ said, I can just check the output value
Обсуждают сегодня