Should I always check for NULL pointer? I have that

Just check for NULL at all callsites instead: assert(stack); push(stack, 42); and then step 2: remove the asserts at all callsites where it's obvious it's not NULL, like: stack_t stack = ...; push(&stack, 42); // no assert needed ofc

0

11 месяцев назад

Thomas

Thomas
Just check for NULL at all callsites instead: asse...

The theory is that step 2 will remove most or all assertions

0

11 месяцев назад

²

Thomas
Just check for NULL at all callsites instead: asse...

You mean, just transfer responsibility for error/null checking to user?

0

11 месяцев назад

Chiyando

²
You mean, just transfer responsibility for error/n...

No, he means don't check it at times when it is obviously not needed

0

11 месяцев назад

Thomas

Chiyando
No, he means don't check it at times when it is ob...

Both

0

11 месяцев назад

Thomas

²
You mean, just transfer responsibility for error/n...

Some functions take pointers that can be NULL, most don't, ones that don't shouldn't check, they should just segfault

0

11 месяцев назад

狐, シテ - Vlad Автор вопроса

Thomas
Some functions take pointers that can be NULL, mos...

Then, how do I unit test them if the app just segfaults? Or should I check only how it behaves given valid data? I'm just switching from C# to C and it highly contradicts how I used to work and deal with such situations since I treat pointers much like reference types in C# (it quite a bit helped me to get how they work) with addition that I should manually free the memory.

0

11 месяцев назад

Thomas

狐, シテ - Vlad
Then, how do I unit test them if the app just segf...

1. a segfault is a valid test suite failure, just not a very descriptive one 2. Yes, only test for valid data ofc, garbage in -> garbage out Imagine the scenario

0

11 месяцев назад

狐, シテ - Vlad Автор вопроса

Thomas
1. a segfault is a valid test suite failure, just ...

I will try that approach. Writing code expecting you will get in your functions what you want is new to me. Usually my code starts from a couple of if statements validating an input data.

0

11 месяцев назад

Thomas

狐, シテ - Vlad
I will try that approach. Writing code expecting y...

In this case validation is not free, and you usually control all the callsites too

0

11 месяцев назад

² · Accepted Answer

²

Yep

0

11 месяцев назад

Похожие чаты

Should I always check for NULL pointer? I have that

17 ответов

Похожие вопросы