C / C++

Should I always check for NULL pointer? I have that

habit from c#.

17.12.2023

17 ответов

63 просмотра

Yep

17.12.2023

狐, シテ - Vlad Автор вопроса

²
Yep

roger that

17.12.2023

BSP

Is null valid to pass in?

17.12.2023

Chiyando

I just assert not null

17.12.2023

Chiyando
I just assert not null

It does work in "release" build?

17.12.2023

Chiyando

²
It does work in "release" build?

It's not the same, yeah

17.12.2023

Thomas

I wouldn't

17.12.2023

Thomas

Just check for NULL at all callsites instead: assert(stack); push(stack, 42); and then step 2: remove the asserts at all callsites where it's obvious it's not NULL, like: stack_t stack = ...; push(&stack, 42); // no assert needed ofc

17.12.2023

Thomas

Thomas
Just check for NULL at all callsites instead: asse...

The theory is that step 2 will remove most or all assertions

17.12.2023

Thomas
Just check for NULL at all callsites instead: asse...

You mean, just transfer responsibility for error/null checking to user?

17.12.2023

Chiyando

²
You mean, just transfer responsibility for error/n...

No, he means don't check it at times when it is obviously not needed

17.12.2023

Thomas

Chiyando
No, he means don't check it at times when it is ob...

Both

17.12.2023

Thomas

²
You mean, just transfer responsibility for error/n...

Some functions take pointers that can be NULL, most don't, ones that don't shouldn't check, they should just segfault

17.12.2023

狐, シテ - Vlad Автор вопроса

Thomas
Some functions take pointers that can be NULL, mos...

Then, how do I unit test them if the app just segfaults? Or should I check only how it behaves given valid data? I'm just switching from C# to C and it highly contradicts how I used to work and deal with such situations since I treat pointers much like reference types in C# (it quite a bit helped me to get how they work) with addition that I should manually free the memory.

18.12.2023

Thomas

狐, シテ - Vlad
Then, how do I unit test them if the app just segf...

1. a segfault is a valid test suite failure, just not a very descriptive one 2. Yes, only test for valid data ofc, garbage in -> garbage out Imagine the scenario

18.12.2023

狐, シテ - Vlad Автор вопроса

Thomas
1. a segfault is a valid test suite failure, just ...

I will try that approach. Writing code expecting you will get in your functions what you want is new to me. Usually my code starts from a couple of if statements validating an input data.

18.12.2023

Thomas

狐, シテ - Vlad
I will try that approach. Writing code expecting y...

In this case validation is not free, and you usually control all the callsites too

18.12.2023

Похожие вопросы

C / C++ / Thomas

Anyone wanna be a test subject for a thing?

22.11.2024

7 ответов

C / C++ / Martin Rys

&"C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.42.34433\bin\Hostx64\x64\dumpbin.exe" /EXPORTS C:\Users\Yeet\Tauon\vcpkg\installed\x64-window...

21.11.2024

7 ответов

C / C++ / Jacob

Hi everyone I'm considering writing linker for Windows x86-64 How hard it should be? I want to write it to link rust/cpp programs faster in with parallel ways

19.11.2024

22 ответов

C / C++ / Adrian

@QNeko heey , stream when ?

22.11.2024

4 ответов

C / C++ / Chiyando

This video is really great. https://www.youtube.com/watch?v=QpAhX-gsHMs

09.11.2024

33 ответов

C / C++ / Ashkan

Hi. Does anyone know how I can have standard library headers without installing VS on Windows? I'm trying to code in VSCode with clang to program in C but it dosnet found that...

21.11.2024

2 ответов

C / C++ / Ludovic 'Archivist' Lagouardette

like, question: int b = 99999; is this valid and predictable C?

16.11.2024

15 ответов

C / C++ / Zeynep

Does anyone know how to compile OpenCV with QT Creator?

20.11.2024

6 ответов

C / C++ / Thomas

You don't realize each platform will define it in their own way?