Can someone explain this error?

I found this, you probably need to do cin.ignore(), before first getline call. https://stackoverflow.com/questions/36374710/using-multiple-getline-calls-to-read-multiple-lines

0

09.09.2021

Pavel

By the way, I can give you some suggestions how this code can be improved (from readability and maintainability perspective), do you need it?

0

09.09.2021

Caroline Автор вопроса

Pavel
I found this, you probably need to do cin.ignore()...

ty

0

09.09.2021

Caroline Автор вопроса

Pavel
By the way, I can give you some suggestions how th...

yes i need it, i wanna know your suggestions bro, appreciate it

0

09.09.2021

Pavel

Caroline
yes i need it, i wanna know your suggestions bro,...

First of all, instead of using raw arrays you can use std::vector. It will allow you to do the same logic but without need to call delete manually (so you don't have a chance to forget to do it, especially if your function will have multiple returns in future). So you can just create variables of types std::vector<char> and std::vector<std::string>> and call resize(size) to make them allocate 3 items for you. Then you can use it like you already using it and the items will be deallocated in the end of the function automatically. The pattern that vector uses called RAII. Instead of having a separate array for first letter, you can do one of the following: Either do to upper on the first symbol in the cout call. E.g. cout << toupper(name[i].at(0)) << ...;. Or in your loop you can assign result of toupper back to the first symbol. Something like name[i][0] = toupper(name[i][0]);. I would prefer the second way. If you use vector instead of raw array, you can use range-based loops instead of iterating over i. So your loops will look like: for (auto& line : name){ And you will use line instead of name[i]. And a minor suggestion, it's better not to use using namespace std in real code. It is good for code examples to make them shorter, but in real code it can create issues. https://www.geeksforgeeks.org/using-namespace-std-considered-bad-practice/ Other than that, the code looks good to me. Nice use of transform 👍

0

09.09.2021

Pavel · Accepted Answer

Pavel

Caroline
@gameraccoon when i write Getline(cin, name[i]) In...

What do you mean by "except cin name"?

0

09.09.2021

Похожие чаты

Can someone explain this error?

10 ответов

Похожие вопросы