Hey everyone, after using delete[] to free memory of dynamic

Your string created on stack as array of char (name1 in main()) then you call delete on it in the destructor of Player. And that because of this code in the constructor char* buffer = name; int name_size = strlen(buffer); name = new char [name_size + 1]; this->name = buffer; this->symbol = symbol; You assign name (input parameter) to buffer and then assign buffer to this->name.

0

23.03.2021

German Автор вопроса

Pavel
by the way, why don't you use std::string?

i cannot use std::string on this project (course rules...)

0

23.03.2021

Pavel

German
i cannot use std::string on this project (course r...

Ah, that's bad. Because in C++ we don't write code like this usually, it's very error prone (and extra verbose).

0

23.03.2021

German Автор вопроса

Pavel
Your string created on stack as array of char (nam...

Which way is good to fix it without using std::string?

0

23.03.2021

@^@ ^

German
i cannot use std::string on this project (course r...

what about smart pointers like std::shared_ptr<std::array<char>> ?

0

23.03.2021

Pavel

German
Which way is good to fix it without using std::str...

If feels like the code in the constructor is not entirely correct, you probably wanted to assign result of new directly to this->name? Also, pass name as const char* not char*, then compiler will not let you modify it accidentally

0

23.03.2021

Pavel

German
Which way is good to fix it without using std::str...

also, it seems like you need to do strcpy there, not assign string one to another

0

23.03.2021

German Автор вопроса

Pavel
also, it seems like you need to do strcpy there, n...

OK

0

23.03.2021